Skip to content
This repository has been archived by the owner on Aug 26, 2023. It is now read-only.

Tests #1

Open
friday opened this issue Sep 28, 2018 · 0 comments
Open

Tests #1

friday opened this issue Sep 28, 2018 · 0 comments
Labels
improvement Changes to the current behavior

Comments

@friday
Copy link
Owner

friday commented Sep 28, 2018 •
edited
Loading

Tests are always good. Optimally the lottie-node API should be fully covered, but since it's kind of a niche library and I don't even have After Effects myself (I'm running Linux) I'm blocked by #4.

Example of tests that should be possible:

  • Check the hash of an output (this type of test can be prone to false positives, for example if node-canvas makes changes to antialiasing or font kerning)
  • Check the color of a specific pixel of a PNG export.
@friday friday changed the title Write tests and use less permissive peerDependency-versions Tests Nov 25, 2018
@friday friday added the improvement Changes to the current behavior label Nov 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
improvement Changes to the current behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@friday