Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize generated DDL #11

Open
frioux opened this issue Aug 18, 2012 · 4 comments
Open

Serialize generated DDL #11

frioux opened this issue Aug 18, 2012 · 4 comments
Assignees
Milestone

Comments

@frioux
Copy link
Owner

frioux commented Aug 18, 2012

Early on DBICDH actually generated an array of SQL serialized as JSON (1f0d063). For some dumb reason (ff7f0e7 ?) I removed the code (09bc35e).

This should be put back for goodness sakes! It's much better, esp for databases like oracle where simply splitting on ; is insufficient.

@colinnewell
Copy link

This bug could do with more detail. I could tell that it related to the SQL, but I don't understand what exactly you want to do.

Are you suggesting that we should provide json files with lists of statements? I kind of read this or storing a json list of statements in the version table?

@frioux
Copy link
Owner Author

frioux commented Oct 31, 2016

yeah when the SQL is generated it should store it as json or yaml or something, instead of a flat file of just sql with ";\n" joining the statements.

@colinnewell
Copy link

It sounds like we could do with,

  1. the option to suck in json lists of SQL statements
  2. store the instructions run as json.
  3. improvements to the text file parsing, and possibly warnings (and pointers to json storage) if it looks like we might have misinterpreted the text file as per Statement splitting is relatively brittle #47.

Does anything currently consume the instructions list from the version table? Would that need to be an option?

@frioux
Copy link
Owner Author

frioux commented Oct 31, 2016

nah the stuff in the table is just for auditing. I think you're right re the options. The one other thing to consider is legacy implementations. If you turn on the flag, do we fall back from json to plaintext? Do we offer a tool to upgrade plaintext to JSON? etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants