-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize generated DDL #11
Comments
This bug could do with more detail. I could tell that it related to the SQL, but I don't understand what exactly you want to do. Are you suggesting that we should provide json files with lists of statements? I kind of read this or storing a json list of statements in the version table? |
yeah when the SQL is generated it should store it as json or yaml or something, instead of a flat file of just sql with ";\n" joining the statements. |
It sounds like we could do with,
Does anything currently consume the instructions list from the version table? Would that need to be an option? |
nah the stuff in the table is just for auditing. I think you're right re the options. The one other thing to consider is legacy implementations. If you turn on the flag, do we fall back from json to plaintext? Do we offer a tool to upgrade plaintext to JSON? etc. |
Early on DBICDH actually generated an array of SQL serialized as JSON (1f0d063). For some dumb reason (ff7f0e7 ?) I removed the code (09bc35e).
This should be put back for goodness sakes! It's much better, esp for databases like oracle where simply splitting on ; is insufficient.
The text was updated successfully, but these errors were encountered: