-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace curl completely with rclone #163
base: master
Are you sure you want to change the base?
Conversation
…for the OS partition. Instead, updated code to dynamically download the rclone binary to the SD card if it's not present.
Update: I've also updated |
For testing, I've made a release here https://github.com/marklar423/KoboCloud-rclone/releases/tag/latest |
Hi, thanks a lot for all your work! As this changes a lot regarding the internals of KoboCloud, I would support having it as a separate project. I am willing to give it prominence in the readme file so people can be redirected to this version, but replacing the existing workflow would disrupt too many current users, I believe (including me). |
Hey @fsantini thanks for taking the time to look at my PR. I totally get where you're coming from, this would definitely be a big change for existing users. So, I'll keep my fork maintained, and you can close this as obsolete or wontfix if you like. |
Hi @marklar423 |
This PR is similar to #35, but goes much further to completely remove
curl
as a dependency and userclone
instead.Here's what I did:
curl
binaryrclone
binary if it's missingrclone
binary in the tgz package, but it was too big (50 MiB) to fit on my device's (Kobo Libra 2) system partition (256 MiB, only 20 MiB free).wget
to download it to.add/kobocloud/bin/
which is on the 30 GiB partition on my device.wget
to download NickelDBuskobocloudrc
file as aremote:dir
pair to pass torclone copy
.rclone sync
instead if theREMOVE_DELETED
option is present.README
with instructions reflecting the changes.I've built a new
KoboRoot.tgz
and have been using it on my device (Kobo Libra 2) to sync my Google Drive - it appears to be working well.This is a big departure from the way things work now, but I think it brings massive improvements that make it worth it:
rclone.conf
file, they will be able to use the interactiverclone config
tool to generate the file, which will gently guide them through the process of setting up each remote service.Please let me know your thoughts - I'm happy to discuss further and make changes.