New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minified files are broken in 1.0.0 (npm release) #70

Open

fuhrmanator opened this issue Sep 15, 2024 · 1 comment

Assignees

Owner

fuhrmanator commented Sep 15, 2024

Symptom:

node_modules\gift-pegjs\pegjs-gift.js:1:6567: ERROR: Expected ")" but found "t"

Minify has a bug that caused the 1.0.0 release to be broken (the minified file has unbalanced apostrophes). See coderaiser/minify#127.

fuhrmanator self-assigned this

Owner Author

fuhrmanator commented Sep 15, 2024

Even reverting to an older minify where it supports apostrophes in strings causes the minified parser to fail with the latest grammar.

I will take minify out of the build loop because it's not worth the problems. If developers want to minify it's up to them to find a reliable tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment