Replies: 2 comments 1 reply
-
Good question. I personally do not have a strong preference. What is your choice? In addition, after we provide prebuilt binary for all platforms, codegen's rust version can be almost arbitrary without affecting users |
Beta Was this translation helpful? Give feedback.
-
Hi folks, working on a completely different PR, I needed to know our MSRV to ensure compatibility. In many PRs/issues, we talk about the MSRV, but nowhere is there a magic number or a range. In accordance with our rust edition set to 2018, flutter_rust_bridge/Cargo.toml Line 13 in fe67cb5 I propose that we officially (after testing and CIing, of course) declare this is the first available 2018 edition of Rust, i.e. the oldest version the compiler will let you use anyway, without modifications. Web requires nightly, and, to my knowledge, there may or may not be unstable APIs in other sections of code. I understand that this discussion is concerning the codegen portion of the codebase, but I believe we can all see the benefits in declaring the same MSRV for the entire codebase, as well as the consumable. ASIDE FROM testing, let me know if anyone has input on this front. |
Beta Was this translation helpful? Give feedback.
-
I don't think we have anything like this yet, but it would be important not only for the consumers of this library but also contributors like myself who would like to use newer features of rustc. (This is only for the codegen program, the runtime support library should be able to work with most Rust versions supporting the 2018 edition.)
/cc @fzyzcjy
2 votes ·
Beta Was this translation helpful? Give feedback.
All reactions