From 37b4fa459e24ba00f952b3bb3ddb62b6bd0aa7f1 Mon Sep 17 00:00:00 2001
From: Alireza Heidari <itisalirh@gmail.com>
Date: Mon, 18 Nov 2024 00:00:39 +0100
Subject: [PATCH] Fix license loading logic and improve reactivity

Changes initial licensesLoading state to false
Uses watchImmediate for immediate reactivity on inputLicense
Ensures licenses are fetched only when not already loading
---
 client/src/components/License/LicenseSelector.vue | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/client/src/components/License/LicenseSelector.vue b/client/src/components/License/LicenseSelector.vue
index 5e7384160c6d..a9f55d621e1c 100644
--- a/client/src/components/License/LicenseSelector.vue
+++ b/client/src/components/License/LicenseSelector.vue
@@ -1,6 +1,7 @@
 <script setup lang="ts">
+import { watchImmediate } from "@vueuse/core";
 import { BAlert } from "bootstrap-vue";
-import { computed, ref, watch } from "vue";
+import { computed, ref } from "vue";
 import Multiselect from "vue-multiselect";
 
 import { GalaxyApi } from "@/api";
@@ -31,7 +32,7 @@ const emit = defineEmits<{
     (e: "onLicense", license: string | null): void;
 }>();
 
-const licensesLoading = ref(true);
+const licensesLoading = ref(false);
 const errorMessage = ref<string>("");
 const currentLicense = ref<LicenseType>();
 const licenses = ref<LicenseMetadataModel[] | undefined>([]);
@@ -70,7 +71,9 @@ async function fetchLicenses() {
 }
 
 async function setCurrentLicense() {
-    if (!licenses.value?.length) {
+    if (!licenses.value?.length && !licensesLoading.value) {
+        licensesLoading.value = true;
+
         await fetchLicenses();
     }
 
@@ -79,14 +82,12 @@ async function setCurrentLicense() {
     currentLicense.value = (licenses.value || []).find((l) => l.licenseId == inputLicense) || defaultLicense;
 }
 
-watch(
+watchImmediate(
     () => props.inputLicense,
     () => {
         setCurrentLicense();
     }
 );
-
-setCurrentLicense();
 </script>
 
 <template>