Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"faster version of ClosedSubsets" broke test suite #1

Open
fingolfin opened this issue Mar 7, 2019 · 0 comments
Open

"faster version of ClosedSubsets" broke test suite #1

fingolfin opened this issue Mar 7, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@fingolfin
Copy link
Member

With commit d9ad0a5, the SLA test suite got broken. On https://travis-ci.org/gap-packages/sla/jobs/502455062 we see:

...
testing: /home/travis/build/gap-packages/sla/gaproot/pkg/sla/tst/sla05.tst
########> Diff in /home/travis/build/gap-packages/sla/gaproot/pkg/sla/tst/sla0\
5.tst:126
# Input is:
c:= ClosedSubsets(R);;
# Expected output:
# But found:
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `Dimension' on 1 arguments
########
########> Diff in /home/travis/build/gap-packages/sla/gaproot/pkg/sla/tst/sla0\
5.tst:127
# Input is:
Length(c);
# Expected output:
4844
# But found:
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `Length' on 1 arguments
...

and also this:

########> Diff in /home/travis/build/gap-packages/sla/gaproot/pkg/sla/tst/sla0\
5.tst:170
# Input is:
LeviMalcevDecomposition(K);
# Expected output:
[ <Lie algebra of dimension 3 over Rationals>, 
  <two-sided ideal in <Lie algebra of dimension 20 over Rationals>, 
      (dimension 17)> ]
# But found:
[ <Lie algebra of dimension 15 over Rationals>, 
  <Lie algebra of dimension 0 over Rationals> ]
########

If I may, I'd recommend to do all development via pull requests -- i.e. instead of directly pushing to master, push into a new remote branch and open a pull request for it. Then all tests are run for you, and if they passed, you can merge everything with a button click.

Alternatively, you can of course also work as before, but it might be useful to run the test suite before committing (e.g. via gap tst/testall.g from the package directory).

@fingolfin fingolfin added the bug Something isn't working label Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants