validateArgs bug in "gardenctl logs tf"

[neo-liang-sap]

Describe the bug

Say we have current target stack:

gardenctl get target                       (ccee-m3/default)
target:
- kind: garden
  name: dev
- kind: seed
  name: aws
- kind: namespace
  name: shoot--sretestneo--neo-test-ar

we have a seed targeted

But in logic 16fc236#diff-59f23253994b1605ea49a120ea68de0c2ee3a4240c2825bb741f7b707695211fR80 , gardenctl will fall into return errors.New("No seed or shoot targeted")

this commit is included in #404 - @tedteng could you please check it when you have time? thanks!

To Reproduce

1. target the stack as above
2. run gardenctl logs tf

Expected behavior
As seed is already targeted, gardenctl logs tf should run success

Screenshots

Gardenctl Version (please complete the following information):
latest in master branch

Additional context

[tedteng]

I think you can simply handle this issue by change code to

} else if !(IsTargeted(targetReader, "project") || IsTargeted(targetReader, "shoot") && IsTargeted(targetReader, "seed")) && args[0] == "tf" {

I don't know you will fix it in your PR #436 or I will help you to open a new PR to fix and merge it? let me know what's your next steps?

[neo-liang-sap]

Hi @tedteng , thanks for your comments.
I tried your proposal but seems not working from my side, could you please check and confirm? thanks!


-Neo

[tedteng]

ok, I see, I didn't pay attention to you are target the namespace at that time. As the information provided above, I think you can get the idea of how to handle this kind of issue next time when using IsTargeted , I believe you can add IsTargeted(targetReader, "namespace") inside the code. It should fix the issue now. also fix some typo thank.

} else if !(IsTargeted(targetReader, "project") || IsTargeted(targetReader, "shoot") || IsTargeted(targetReader, "seed") || IsTargeted(targetReader, "namespace")) && args[0] == "tf" {