Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GZ_LAUNCH_VERSION_NAMESPACE not defined? #217

Open
traversaro opened this issue Apr 23, 2023 · 1 comment
Open

GZ_LAUNCH_VERSION_NAMESPACE not defined? #217

traversaro opened this issue Apr 23, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@traversaro
Copy link
Contributor

Environment

  • OS Version: Not relevant
  • Source or binary build? Not relevant

Description

It seems that this library uses a GZ_LAUNCH_VERSION_NAMESPACE macro, but this macro is not defined in config.hh.

  • Expected behavior: The macro is defined.
  • Actual behavior: The macro is not defined, so GZ_LAUNCH_VERSION_NAMESPACE is inserted instead of the versioned namespace.

Steps to reproduce

Inspect the code and see that GZ_LAUNCH_VERSION_NAMESPACE is not defined.

Output

At this point, we can't define GZ_LAUNCH_VERSION_NAMESPACE for gz-launch 6, otherwise we would create an ABI break. However we should remember to define it for gz-launch 7.

@traversaro traversaro added the bug Something isn't working label Apr 23, 2023
@azeey azeey self-assigned this Apr 24, 2023
@azeey
Copy link
Contributor

azeey commented May 1, 2023

Good catch! We could add this to the main branch now.

@azeey azeey moved this to To do in Core development Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

2 participants