You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that this library uses a GZ_LAUNCH_VERSION_NAMESPACE macro, but this macro is not defined in config.hh.
Expected behavior: The macro is defined.
Actual behavior: The macro is not defined, so GZ_LAUNCH_VERSION_NAMESPACE is inserted instead of the versioned namespace.
Steps to reproduce
Inspect the code and see that GZ_LAUNCH_VERSION_NAMESPACE is not defined.
Output
At this point, we can't define GZ_LAUNCH_VERSION_NAMESPACE for gz-launch 6, otherwise we would create an ABI break. However we should remember to define it for gz-launch 7.
The text was updated successfully, but these errors were encountered:
Environment
Description
It seems that this library uses a
GZ_LAUNCH_VERSION_NAMESPACE
macro, but this macro is not defined inconfig.hh.
GZ_LAUNCH_VERSION_NAMESPACE
is inserted instead of the versioned namespace.Steps to reproduce
Inspect the code and see that
GZ_LAUNCH_VERSION_NAMESPACE
is not defined.Output
At this point, we can't define
GZ_LAUNCH_VERSION_NAMESPACE
for gz-launch 6, otherwise we would create an ABI break. However we should remember to define it for gz-launch 7.The text was updated successfully, but these errors were encountered: