Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README installation instructions #434

Open
torlarse opened this issue Jul 14, 2023 · 9 comments · Fixed by #435
Open

README installation instructions #434

torlarse opened this issue Jul 14, 2023 · 9 comments · Fixed by #435
Labels
bug Something isn't working

Comments

@torlarse
Copy link

torlarse commented Jul 14, 2023

Description

  • Expected behavior:
    Installation instructions in README, for the currently "correct" combination of ROS and Gazebo (Humble + Fortress).

  • Actual behavior:
    Installation instructions for ROS Rolling in several branches README.

Steps to reproduce

Just read the README for the different branches, for example

https://github.com/gazebosim/ros_gz/tree/ros2#install

or

https://github.com/gazebosim/ros_gz/tree/humble#install

Since this pattern shows in several branches, I'm not sure if this is actually an error. Since the docs point to this repo for installing the "correct" ros_gz version, it should reflect that? Also the Gazebo answers site seems kinda sleepy, so I'm posting this "bug" here.

@torlarse torlarse added the bug Something isn't working label Jul 14, 2023
@osrf-triage osrf-triage added this to Inbox in Core development Jul 14, 2023
@torlarse
Copy link
Author

torlarse commented Jul 14, 2023

I'm also confused by the wording in the ROS and Gazebo install docs

I suspect the command

sudo apt-get install ros-${ROS_DISTRO}-ros-gz

is the valid command for all ROS distros, even the currently supported one? But the text says this will install ros_gz AND Gazebo?

Screenshot from 2023-07-14 21-40-39-mh

@torlarse
Copy link
Author

torlarse commented Jul 15, 2023

@ahcorde it seems my issue is related to #338

It would be nice to read how to properly install ros_gz from a binary, that's all :)

@ahcorde ahcorde mentioned this issue Jul 17, 2023
8 tasks
@ahcorde
Copy link
Collaborator

ahcorde commented Jul 17, 2023

Fixed here #435

I will backport this to iron and humble.

Core development automation moved this from Inbox to Done Jul 17, 2023
@torlarse
Copy link
Author

@ahcorde thanks for being so responsive, appreciated.

Please pardon me for being slow to comprehend, but I'm still confused. To me, it seems like all the branches of ros gz still require ROS Rolling (rolling dev distro?).

For example in the humble branch

https://github.com/gazebosim/ros_gz/tree/humble

README:

This branch supports ROS Rolling. See above for other ROS versions.

,or

Be sure you've installed ROS Rolling (at least ROS-Base). More ROS dependencies will be installed below.

, and the installation command is

 sudo apt install ros-rolling-ros-gz

The binary link regarding ROS Humble and Fortress does not solve my confusion. Please let me know if there is something obvious I haven't understood.

@ahcorde ahcorde mentioned this issue Jul 18, 2023
8 tasks
@ahcorde ahcorde reopened this Jul 18, 2023
@ahcorde
Copy link
Collaborator

ahcorde commented Jul 18, 2023

sorry, we are creating branches from rolling when there is a new release and sometime we forgot to revisit the documentation.

How about this ?

#438

@torlarse
Copy link
Author

That looks much better, thanks!

Just one question left: from the documentation/ web page I mentioned:

https://gazebosim.org/docs/fortress/ros_installation#installing-gazebo-with-older-versions-of-ros

, the

sudo apt install ros-humble-ros-gz

command installs both ros_gz AND Gazebo. What if the user already has a valid and "correct" Gazebo installation?

@ahcorde
Copy link
Collaborator

ahcorde commented Jul 18, 2023

If you have already installed Gazebo, then these packages will not be installed because they are already in your system.

The second option is to have a workspace with Gazebo compiled from source, in this case you should source this workspace and that's all.

@torlarse
Copy link
Author

OK thanks.

Yes, I was aware of the possibility of compiling from source, as in the project template. However, I think I prefer minimizing the mix of simulation and ROS control files, in the repo being cloned to the Pi.

@azeey
Copy link
Contributor

azeey commented Jan 4, 2024

gazebosim/docs#420 addresses the comment about "Older" versions. I think the READMEs have also been updated, so can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants