Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should provide option to set shell=False in launch files #563

Open
azeey opened this issue Jun 21, 2024 · 0 comments
Open

Should provide option to set shell=False in launch files #563

azeey opened this issue Jun 21, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@azeey
Copy link
Contributor

azeey commented Jun 21, 2024

Due to ros2/launch#757 Gazebo launched by gz_sim.launch.py does not shut down cleanly. We should provide a way to set shell=False to workaround this issue. Most users probably don't need shell=True, which is mainly used to expand environment variables and file globs [1] since launch provides a way to set environment variables and find absolute paths to files, so we might consider making shell=False, the default.

@azeey azeey added the bug Something isn't working label Jun 21, 2024
@azeey azeey added the help wanted Extra attention is needed label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: To do
Development

No branches or pull requests

1 participant