Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser_urdf should not ignore origin of floating and planar joints #1282

Open
scpeters opened this issue May 17, 2023 · 1 comment
Open

parser_urdf should not ignore origin of floating and planar joints #1282

scpeters opened this issue May 17, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@scpeters
Copy link
Member

Desired behavior

While investigating a question related to the reference frame used for floating URDF joints, I noticed that parser_urdf.cc currently takes no action when encountering floating and planar joints (see the switch logic where no value for jtype is set and the subsequent if block). This causes the //joint/origin tag to be ignored for these joint types, when it should be passed along to the SDFormat file in the link pose.

Alternatives considered

Implementation suggestion

Additional context

@scpeters scpeters added the enhancement New feature or request label May 17, 2023
@osrf-triage osrf-triage added this to Inbox in Core development May 17, 2023
@scpeters scpeters added the good first issue Good for newcomers label May 17, 2023
@scpeters
Copy link
Member Author

A first step towards fixing this would be to add a URDF file with a floating joint that has a non-zero origin to the test/integration folder.

A second step would be to write a test that parses this file and expects the child link of the floating joint to have a pose that matches the value from the floating joint origin.

A third step would be to update parser_urdf.cc to translate the floating joint origin to the child link, perhaps by adding a frame for the floating joint and defining the child link pose relative to that frame.

@azeey azeey moved this from Inbox to To do in Core development May 22, 2023
@azeey azeey added the help wanted Extra attention is needed label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: To do
Development

No branches or pull requests

2 participants