Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link_state velocity, acceleration, and wrench data should not use pose type #1366

Open
scpeters opened this issue Jan 31, 2024 · 0 comments
Open
Labels
Breaking change Breaks API, ABI or behavior. Must target unstable version. enhancement New feature or request

Comments

@scpeters
Copy link
Member

Desired behavior

The following elements in the link_state specification all use the pose data type, even though the rotational components should not be represented by a quaternion.

  • //state/link/velocity
  • //state/link/acceleration
  • //state/link/wrench

I'm guessing this is because there is no vector6 type to handle the spatial vectors. Since it can be confusing to remember whether the translational or rotational components should go first (SDFormat and URDF pose put translation first, while DART and many spatial algebra formulations put rotation first), an alternative is to split them into two vector3 types.

Alternatives considered

We could add a gz::math::Vector6 to support a vector6 type, but I think it may be less confusing to use two vector3s.

Implementation suggestion

Additional context

@scpeters scpeters added enhancement New feature or request Breaking change Breaks API, ABI or behavior. Must target unstable version. labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change Breaks API, ABI or behavior. Must target unstable version. enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

1 participant