Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated //joint/thread_pitch in SDFormat 1.12 #1401

Open
scpeters opened this issue Apr 11, 2024 · 0 comments
Open

Remove deprecated //joint/thread_pitch in SDFormat 1.12 #1401

scpeters opened this issue Apr 11, 2024 · 0 comments
Labels
Breaking change Breaks API, ABI or behavior. Must target unstable version. enhancement New feature or request

Comments

@scpeters
Copy link
Member

Desired behavior

The //joint/thread_pitch element was deprecated in 1.10 in favor of //joint/screw_thread_pitch (see #1125 and #1168). The C++ APIs Joint::ThreadPitch and Joint::SetThreadPitch are not yet deprecated. We should consider removing the deprecated element in SDFormat 1.12 and deprecating the SDFormat APIs.

Alternatives considered

Deprecate the C++ APIs first and then remove them together.

Implementation suggestion

Additional context
@scpeters scpeters added enhancement New feature or request Breaking change Breaks API, ABI or behavior. Must target unstable version. labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking change Breaks API, ABI or behavior. Must target unstable version. enhancement New feature or request
Projects
Core development
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scpeters