Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Password send in clear text #17

Open
nanohayder opened this issue Oct 11, 2017 · 2 comments
Open

SQL Password send in clear text #17

nanohayder opened this issue Oct 11, 2017 · 2 comments

Comments

@nanohayder
Copy link

Thank you so much for this great plugin it helped us a lot but we have one issue with it is that the SQL Credentials and the DB name and the DB IP all are send in the url in clear text even if it's encrypted it will show up on the client side in the developer tools is there anything we can do so that we only send a request for the data without the credentials? if it can be done using proxy and all the data is handled from the client side that would be even better?

Thanks

@gbrian
Copy link
Owner

gbrian commented Oct 13, 2017

Hi @nanohayder ,

We can think on having a settings file for this so you define a datasourceid on the url instead whole connection string.
Currently (not sure) but setting as Proxy datasource a non admin user should not be able to see it as is grafana backoffice running the request not the client. If it's set as Direct it is the browser running the request.

@nanohayder
Copy link
Author

Hi @gbrian

I think if we can't make as a proxy and it has to be direct then I think we need to add authentication to the request same Grafana as they have done with mysql driver they are sending the query with an id for the data source but the request is authenticated using grafana.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants