Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use destructive button style confirm button on alerts for deleting files, turning off printer etc. #679

Open
SebastianOsinski opened this issue Dec 5, 2023 · 1 comment
Open

Use destructive button style confirm button on alerts for deleting files, turning off printer etc. #679

SebastianOsinski opened this issue Dec 5, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@SebastianOsinski
Copy link

SebastianOsinski commented Dec 5, 2023 •
edited
Loading

Hi! As stated in the title - I think using destructive button style for confirm (Yes) buttons on alerts for file deletion, turning off printer and other dangerous actions would really benefit the UX of the app. This would make the Yes button red and stand out. What do you think? If this is an improvement you like, I'm down to create a PR in the following days.
@gdombiak
Copy link
Owner

gdombiak commented Dec 7, 2023

Hi @SebastianOsinski ,

This sounds like a nice idea. Waiting for the PR to check it out and merge it.

Thanks,
Gaston

@gdombiak gdombiak added the enhancement New feature or request label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gdombiak @SebastianOsinski