Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the equal pixels transparent #10

Open
2 tasks
flore77 opened this issue Aug 27, 2015 · 4 comments
Open
2 tasks

Make the equal pixels transparent #10

flore77 opened this issue Aug 27, 2015 · 4 comments

Comments

@flore77
Copy link
Contributor

flore77 commented Aug 27, 2015

Need

As a user
I need to see the differences immediately
So that I don't struggle to see the little ones

Deliverables

  • Possibility to make the equal pixels of the diff image transparent
  • tests

test

rect

diff

Solution

Adding another field to the options object:

options = {
  transparency: {Number} between 0 - 255 // default 255
};

Modifying the setPixel method from the prototype of PNGOut, to receive another parameter, that will be set on the alpha channel, i.e this._png.data[idx +3].

chrisdeely added a commit to chrisdeely/looks-same that referenced this issue Oct 20, 2017
… control the alpha of unchanged pixels
@kunwardeep
Copy link

anything stopping us merging this ?

@sipayRT
Copy link
Member

sipayRT commented Feb 26, 2018

sorry, will check it today

@maksim-kucherov
Copy link

maksim-kucherov commented Mar 1, 2018

The fix will really help us. We need some universal automatic way to find out 'diff zone' in diff images. So, transparent pixel will be a marker of 'diff pixel'.

@mickaelperrin
Copy link

Any update on this ?

chrisdeely added a commit to chrisdeely/looks-same that referenced this issue Jan 27, 2023
… control the alpha of unchanged pixels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants