Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single pixel diffs are not ignored #34

Open
jwir3 opened this issue Jul 3, 2018 · 0 comments
Open

Single pixel diffs are not ignored #34

jwir3 opened this issue Jul 3, 2018 · 0 comments

Comments

@jwir3
Copy link

jwir3 commented Jul 3, 2018

Using looks-same v3.3.0.

Note that the reference image was generated using WebGL on a Macbook Pro 2015, whereas the generated image is generated using a docker image running Ubuntu with osmesa.

looks-same configuration:

await looksSameAsync(actual, expected,
                                           {
                                             tolerance: tolerance,
                                             pixelRatio: self._getDPI(), // set to device DPI
                                             ignoreAntialiasing: true,
                                             ignoreCaret: true
                                           });

await looksSame.createDiffAsync({
        reference: this._getReferenceFilePath(),
        current: this.getActualFilePath(),
        diff: this._getDiffFilePath(),
        highlightColor: '#ff00ff',
        tolerance: tolerance,
        pixelRatio: self._getDPI(),
        ignoreAntialiasing: true,
        ignoreCaret: true
      });

reference image:
single-triangle-colors

generated image:
single-triangle-colors

diff:
single-triangle-colors

The lower left pixel of the triangle is showing up as different, and the test is failing due to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant