Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New QC check- ensure that EC xrefs exist #29320

Closed
pgaudet opened this issue Nov 28, 2024 · 4 comments · Fixed by #29372
Closed

New QC check- ensure that EC xrefs exist #29320

pgaudet opened this issue Nov 28, 2024 · 4 comments · Fixed by #29372
Assignees
@balhoff
Labels
QC

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Nov 28, 2024

Hi @balhoff

See comment here:
#27532 (comment)

We had a xref to a non-existing EC term. We should have look up lists to make sure that we only use valid ECs (I think we already have that for RHEA?

Thanks, Pascale
@pgaudet pgaudet added the QC label Nov 28, 2024
@balhoff balhoff mentioned this issue Dec 4, 2024
Merged
@balhoff
Copy link
Member

balhoff commented Dec 4, 2024

@pgaudet I implemented the check in #29372. However it found an error that appears to be "on purpose"; EC:1.14.13.253 is not published yet on Expasy (#29305 (comment)).

Should we make a policy for this?

@balhoff
Copy link
Member

balhoff commented Dec 5, 2024

Previous discussion: #27997

@pgaudet
Copy link
Contributor Author

pgaudet commented Dec 9, 2024

Right, the GO policy is that we use Expasy as the source of truth.

@pgaudet
Copy link
Contributor Author

pgaudet commented Dec 9, 2024

Hi @balhoff
I removed the problematic EC. You can go ahead and complete this.

@pgaudet pgaudet changed the title New QC check- ensure that xrefs exist New QC check- ensure that EC xrefs exist Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balhoff balhoff

Labels
QC
Projects
Ontology technical essentials and proactive maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check that EC xrefs are known ECs. geneontology/go-ontology
2 participants
@balhoff @pgaudet