Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity node for reaction should be a process if GO BP is curated at Reactome #318

Open
dustine32 opened this issue Jun 13, 2024 · 5 comments
Assignees

Comments

@dustine32
Copy link
Collaborator

dustine32 commented Jun 13, 2024

Here is how the reaction R-HSA-163743 "Transcriptional activation of ACACA by ChREBP:MLX" (the middle box) is currently converted:
image

There is no GO MF term or controller so the activity is Molecular Event. Reactome has curated a GO BP term so it is added and connected to the reaction via a "part of" relation.

The new conversion requirements should instead result in this pattern:
image
The Molecular Event activity is gone with the Reactome-curated GO BP term now anchoring the "has input" and "has output" edges and connected to the preceding reaction via a "part of" relation.

In other words:

  1. Remove edges from the reaction to its preceding reaction (usually a causal relation)
  2. Replace this edge with "part of"
  3. Replace reaction term with curated GO BP term
  4. Don't create a new individual node for the GO BP

image
This rule should apply when a reaction class is Molecular Event (no GO MF term) and has a curated GO BP term. As discussed on the 2024-06-13 Reactome weeds call (@ukemi, @deustp01, @vanaukenk can confirm), a curated BP term should also override any inference of transporter activity in the conversion.

The code should decide which relation to connect between the reaction's curated BP node and its preceding activity node by fetching the preceding node's MF term and checking if the BP term is in the MF term's "part of" closure (ancestor terms). If yes, the relation will be "part of," otherwise the relation will be "causally upstream of".

@dustine32 dustine32 self-assigned this Jun 13, 2024
@dustine32
Copy link
Collaborator Author

@ukemi @deustp01 Plugging in this change and running the tests, our transport test example reaction (R-HSA-201669 in model R-HSA-201681) has changed because it's curated to a GO BP term. Showing the reaction before my change:
image
And after:
image
As you can see, the location info has been discarded along with the inferred "transport activity" function term. Is this ok with you?

@ukemi
Copy link

ukemi commented Jun 19, 2024

Hi @dustine32. Yes and no. This is something we should discuss on a weeds call. For nuclear import, we have been inferring a transporter activity and hand waving that the enabler would be the nuclear pore. We need to discuss whether this is ok. If not, we have a biological process called 'import into the nucleus'. I think that process is a better asserted match for the black box reaction below that the regulation BP. I will put it on the agenda for a future call.

@deustp01
Copy link
Collaborator

I think that process is a better asserted match for the black box reaction below that the regulation BP.

Questions, perhaps to set up that weeds discussion

  • The textbook description of getting. cargo across the nuclear envelope via the nuclear pore (in either direction) distinguishes multiple steps enabled by multiple soluble accessory proteins and multiple proteins anchored in the nuclear pore, which sounds like a process, but at the same time under normal physiological conditions once a cargo starts the trip it always completes it, so all these steps can be viewed in the same way as the multiple intermediates formed in the course of hydrolysis of a peptide bond by a serine protease. So, we need a convention. Would the process / blackBoxEvent (analogous to the "gene expression" process convention we are working our way towards for transcriptional regulation of gene expression) work here as well?
  • Inferring a transporter activity: again, the textbook has it that everything over a certain size must interact with pore components as above in order to traverse the pore, so it seems like a very conservative inference to assert that protein or RNA above that minimum size follows the textbook route even though it has not been individually studied in experiments. Or am I missing something?

@ukemi
Copy link

ukemi commented Jun 19, 2024

You're not missing anything. I would argue for the import process assertion. I think we are seeing over and over that the inferred transporter activities are often problematic. It was a nice idea, but there are lots of exceptions where what is represented is actually a process. I still think we should discuss it with the other curators.

@deustp01
Copy link
Collaborator

I still think we should discuss it with the other curators.

Definitely - exactly as for the transcriptional regulation we want to come up with a broadly useful annotation standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants