-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break out mechanism->GO mappings to YAML file #18
Comments
Actually, this format's way more readable:
|
@dustine32 Why is there a 'relation' mapped for each mechanism? It is not a one-to-one mapping, right? (i.e, one mechanism can have different type of causal relation) or does 'relation' refers to something else? |
@vtoure Right, the relation column shouldn't be 1:1 for mechanisms. I just quickly added those examples for the ticket. @thomaspd was going to add a relation column to the paper table but I'm actually not sure what the values will look like. I could see the cardinality being zero-to-many with zero just meaning use the existing default causal relation logic we've already coded. This probably relates to some of the paper doc comments:
Currently, this |
Make a parsable YAML file for maintaining the mappings between SIGNOR mechanisms and GO terms:
This will move the mappings out of
pathway_connections.py
, where they are currently hard-coded:The code should simplify to something like:
Also adding a "relation" field for each mapping. Note the example relation assignments above are made up by me. I believe @thomaspd will be adding this field to the same table in the paper so I can just populate from that.
The text was updated successfully, but these errors were encountered: