Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display only causal models on GO-CAM site #20

Open
dustine32 opened this issue Sep 28, 2022 · 14 comments
Open

Display only causal models on GO-CAM site #20

dustine32 opened this issue Sep 28, 2022 · 14 comments
Assignees
Labels
enhancement New feature or request

Comments

@dustine32
Copy link
Contributor

As suggested by @thomaspd, we should only show the most relevant (i.e., causal) GO-CAM models on the GO-CAM browser site.

I believe a fast way (perhaps we could call it a hack) to implement this is to just add the ?causlmf=2 parameter to the API call used to generate the cached gocam-models.json file. The other three files shouldn't require any change as they're just lookup files for the main gocam-models.json file.

@kltm
Copy link
Member

kltm commented Sep 29, 2022

Ah yes, here's the other one. Let's talk when you're back on making sure we're on the same page with geneontology/minerva#448 .

@ValWood
Copy link

ValWood commented Sep 29, 2022

Whre is the GO-CAM browser. site?

@pgaudet
Copy link

pgaudet commented Sep 29, 2022

GO-CAM browser site [edited to correct perma-url -kltm]

@kltm
Copy link
Member

kltm commented Sep 29, 2022

@dustine32 has a possibly easy upfront fix with geneontology/pipeline#302. Testing now.

@kltm
Copy link
Member

kltm commented Sep 29, 2022

@pgaudet We may wrap this before even starting up. With the fix that @dustine32 has, http://geneontology.org/go-cam is now displaying 217 models and is quite snappy. Is this a sufficient fix for now?

@ValWood

This comment was marked as outdated.

@pgaudet
Copy link

pgaudet commented Oct 4, 2022

Can you explain what this is doing ?

217 models seem a bit modest to me - is that all the connected models we have?

  • I would expect this one to be in: gomodel:6246724f00001921
    It does show in Alliance: https://www.alliancegenome.org/gene/HGNC:20749
    but when I search for gene name in the GO-CAM browser (ZDHHC20)I get 0 results.

  • Also, I would expect gomodel:60ad85f700000058 NOT to be in; there some connected activities, but these are binding, and especially, there are many unconnected activities. Interestingly, this one is NOT in the mouse Alliance Atf2 page: https://www.alliancegenome.org/gene/MGI:109349

Are we using different rules than Alliance?

Thanks, Pascale

@pgaudet
Copy link

pgaudet commented Oct 5, 2022

@pmasson55 estimates that about 100 Swiss-Prot models might be missing

@ValWood
Copy link

ValWood commented Oct 5, 2022

I thought it was low. I tried to browse by species. "elegans" gave 2 models.

@dustine32
Copy link
Contributor Author

@pgaudet In general, it's querying all models containing a chain of at least two consecutive causal relations ("causally upstream of or within" RO:0002418 or descendants) connecting MF nodes. The actual query is here.

  • For gomodel:6246724f00001921 ZDHHC20-ZDHHC9 Palmitoyltransferase activity of Sars-Cov-2 S protein (Human-Sars-Cov-2), correct, this should be included in the GO-CAM browser site but for some reason is not picked up. And oddly it is showing up in the "by gene" query used by the Alliance gene page.
  • For gomodel:60ad85f700000058 Atf2 mouse, I can see why this model is picked up by the causal query:
    image
    It's kind of hard to see what the edges here are but they are "causally upstream of", and this chain of at least two consecutive causal relations between MFs is all that the query requires. Though, again, I agree that it's strange this model is not displayed on the Alliance gene page for Atf2 Mmus.

The query to retrieve models "by gene" for the Alliance site should be very similar to the "all causal models" query used for the GO-CAM browser site, but your examples here show that there is some difference that needs to be fixed. I'll make a ticket in the api-gorest-2021 repo to debug this. @pgaudet Thanks for the examples!

@pgaudet
Copy link

pgaudet commented Oct 5, 2022

Thanks for the detailed reply @dustine32 !

@kltm
Copy link
Member

kltm commented Dec 15, 2022

@dustine32 I wanted to follow up on this a little and make this is current. Looking at our current script, we have:

wget http://localhost:8888/models?causalmf=2 -O gocam-models.json'

that is generating the json that gets put into the release. This then gets propagated out (automatically) to the API now defined by https://github.com/geneontology/api-gorest-2023, correct? While we have a more expansive version of this with tagging models in metadata, this first pass is done, correct?

@dustine32
Copy link
Contributor Author

@kltm Oh right, I believe this ticket is done.

And actually, this GO-CAM site pulls these JSONs directly from S3 rather than using a GO-CAM API passthrough:

let url = "https://go-public.s3.amazonaws.com/files/gocam-models.json"

@kltm
Copy link
Member

kltm commented Dec 15, 2022

@dustine32 yes, right you are; pushed on this bonus release pipeline: https://github.com/geneontology/pipeline/blob/f068cce4a3c1b84869e2f4cf501ac5b6c57e2e52/Jenkinsfile#L509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

4 participants