Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out app.conflicts usage #4

Open
doowb opened this issue Jan 24, 2018 · 2 comments
Open

Split out app.conflicts usage #4

doowb opened this issue Jan 24, 2018 · 2 comments

Comments

@doowb
Copy link
Member

doowb commented Jan 24, 2018

As mentioned in this updater-contributing issue, I'd like to use generate-contributing to be able to generate new contributing files if they don't exist when updating projects.

generate-contributing currently expects app.conflicts to exist which relies on other generate features that update doesn't have. I'm proposing that we split out the app.conflicts part and use a library that can be directly used in generate-contributing. This will allow us to use generate-contributing as an updater in updater-contributing.

@jonschlinkert
Copy link
Member

I'm proposing that we split out the app.conflicts part and use a library that can be directly used in generate-contributing

It seems like we should add the conflicts plugin to update. thoughts?

@doowb
Copy link
Member Author

doowb commented Jan 25, 2018

I think that's a good idea.

I just realized this morning that updater-gitignore will show a conflicts message when updating the .gitignore file. Maybe I was configuring something wrong and it the conflicts plugin is already available. If that's the case, then we wouldn't need to change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants