PB-1212: Allow delete last point by button when on line editing mode. #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d vertex button overlay
ismailsunni
requested review from
ltshb,
pakb and
ltkum
and removed request for
ltshb
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
pb-1212-allow-delete-last-point-on-editing-mode
|
| Run status |
|
| Run duration | 04m 01s |
| Commit |
|
| Committer | Ismail Sunni |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
212
|
| View all changes introduced in this branch ↗︎ | |
pakb
reviewed
Nov 26, 2024
| @@ -38,6 +39,33 @@ const isDrawingLineOrMeasure = computed(() => | |||
| currentDrawingMode.value | |||
| ) | |||
| ) | |||
| const selectedEditableFeatures = computed(() => store.state.features.selectedEditableFeatures) | |||
| const selectedLineString = computed(() => { | |||
| if (selectedEditableFeatures.value && selectedEditableFeatures.value.length > 0) { | |||
There was a problem hiding this comment.
if (selectedEditableFeatures.value?.length > 0) { is fine too
| const selectedEditableFeatures = computed(() => store.state.features.selectedEditableFeatures) | ||
| const selectedLineString = computed(() => { | ||
| if (selectedEditableFeatures.value && selectedEditableFeatures.value.length > 0) { | ||
| const selectedFeature = selectedEditableFeatures.value[0] |
There was a problem hiding this comment.
can there be more than one feature selected while drawing?
Comment on lines
+46
to
+54
| if ( | ||
| selectedFeature.geometry.type === 'LineString' && | ||
| (selectedFeature.featureType === EditableFeatureTypes.LINEPOLYGON || | ||
| selectedFeature.featureType === EditableFeatureTypes.MEASURE) | ||
| ) { | ||
| return selectedFeature | ||
| } | ||
| } | ||
| return null |
There was a problem hiding this comment.
if not, we could transform this in a simple
return selectedEditableFeatures.value.find((feature) => {
return feature.geometry.type === 'LineString' &&
[EditableFeatureTypes.LINEPOLYGON, EditableFeatureTypes.MEASURE].includes(feature.featureType))
})
Which will also return null if there's no match
pakb
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link