Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always get the address id #1164

Open
jbelien opened this issue Oct 1, 2022 · 3 comments
Open

Always get the address id #1164

jbelien opened this issue Oct 1, 2022 · 3 comments

Comments

@jbelien
Copy link
Member

jbelien commented Oct 1, 2022

[...]
is it possible to get the address id also when the provider list the results ..

For example arcgis have an id to identify that address, its possible to get that info also on the result array?

Originally posted by @mrelliot69 in #1163 (comment)

@jbelien
Copy link
Member Author

jbelien commented Oct 1, 2022

Some providers return an identifier for the address some don't.
It really depends on the provider (either because the external API do not return an identifier, or because it has not been implemented in the Geocoder PHP provider).
Nothing we can do about the first case, but if it's missing in our provider, we can easily add it (via a PR).

@mrelliot69
Copy link

In this case for example the arcgis and the mapbox one return allways the id, but when getting that info using the library , only returns the info like address, latitude, longitude,... but never the id

If we can add that, that would be great

@jbelien
Copy link
Member Author

jbelien commented Oct 1, 2022

If it's provided by the external API, it's definitely not an issue to add it to our providers.

PR are more than welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants