Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App layout and behavior #13

Open
martinRenou opened this issue Jun 20, 2024 · 4 comments
Open

App layout and behavior #13

martinRenou opened this issue Jun 20, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@martinRenou
Copy link
Member

martinRenou commented Jun 20, 2024

signal-2024-06-20-091409

  • Browser: The browser allows creating data sources and layers. It behaves similarly to the QGIS browser. Upon drag and drop onto the main view, it creates the selected source/layer (see video down below).
  • Data sources: List the currently loaded sources (rendered similarly to the file browser's file list of JupyterLab). Upon click, the source shows up in the Grid View (if applicable), and the Properties tab shows the current filters. See Grid view and filtering of data sources #12.
  • Layers: List the layer groups (rendered similarly to the file browser's file list of JupyterLab). Upon click, its data source is shown in the Grid View (if applicable) and the Properties tab shows the layer properties (colors, raster layer url, api key, etc).
  • Map View: Show the map viewer. See Map viewers #7

For reference, this is how QGIS's browser behaves (drag and drop from the browser to the map view):

Screencast.from.2024-06-20.09-23-59.mp4

The Layers tab list the layers and renders very similarly to the file browser's file list of JupyterLab. It shows a context menu upon right click, allowing to remove/rename the layer or change its properties:

Screencast.from.2024-06-20.09-24-45.mp4
@martinRenou martinRenou added the enhancement New feature or request label Jun 20, 2024
@brichet
Copy link
Collaborator

brichet commented Jun 20, 2024

Maybe the GridView and Properties could be in the same place (with tabs), not sure they need to be displayed at the same time. They could both be under the map
If I'm not mistaken, both are interacting with a specific layer. That could make sense to have the "layer tools" together, and would avoid overloading the interface.

@martinRenou
Copy link
Member Author

I think that's two different things, the Properties tab will allow changing visual properties of the selected layer, while the Grid Viewer will allow visualizing the data source.

It's basically having the viewers in the middle (map/layers viewer on top, data viewer on the bottom), and having controls on the left and right panels.

@martinRenou
Copy link
Member Author

This page design is shamelessly stolen from felt and mixing it with the QGIS browser interface.

I agree overloading the interface is not good, but the user can always move/resize and close tabs.

@martinRenou
Copy link
Member Author

In order to resolve the issue you mention, nothing stops us from reusing the same approach as felt and not showing the data source viewer by default. When clicking on the layer on the left panel, it shows the properties (style, filters) of the currently selected layer on the right panel. And you can open the grid viewer/data viewer on the bottom:

Screencast.from.2024-06-20.10-04-25.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants