Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclickable links on the new site #904

Closed
Detroit70 opened this issue Dec 1, 2023 · 8 comments
Closed

Unclickable links on the new site #904

Detroit70 opened this issue Dec 1, 2023 · 8 comments
Labels
-medium- Difficulty to fix: medium Contributions welcomed Feel free to contribute to the project enhancement New feature or request _LOW Low: Not user blocking new-theme

Comments

@Detroit70
Copy link

All links that were clickable on the old version are no longer clickable on the new one
old link
new link
Another examples
https://geokrety.org/ru/geokrety/GK15C5D
https://geokrety.org/ru/geokrety/GK104FC
AlsoI know many other examples
@kumy
Copy link
Member

kumy commented Dec 1, 2023

I'm really sorry for that. Some data seems to have been lost during the transition GK description transition to markdown 😵

@kumy
Copy link
Member

kumy commented Dec 26, 2023

What could be done:

  • create a new db migration to create a new column in the GK table
  • import raw description from last GKv1 backup (Only me can do this step)
  • implement a button to "revert to GKv1 raw content"
  • Let user fix the formatting

Contributions are welcome!

@kumy kumy added enhancement New feature or request -medium- Difficulty to fix: medium new-theme _LOW Low: Not user blocking Contributions welcomed Feel free to contribute to the project labels Dec 26, 2023
@Detroit70
Copy link
Author

From what you suggested, I would like to ask you to implement the following function on the new site, so that anyone can make edits on the new version in independent mode, transferring links from the old version, that is
implement a button to "revert to GKv1 raw content"

How can this be done and can we be helpful in carrying out this task?

@kumy
Copy link
Member

kumy commented Jan 10, 2024 •
edited
Loading

So, I pushed 2 commits f6872f3 dc4407e

That will add a new button in from tof the "Mission" label
image

On click it open a modal with the raw old content
image

It is testable on https://new-theme.staging.geokrety.org

I will push to prod once the workflow finish (and I should not forget to import the data).
It will be available in v2.41.0

@kumy
Copy link
Member

kumy commented Jan 10, 2024

Done on prod.

How can this be done and can we be helpful in carrying out this task?

There are new strings to translate on crowdin, you may help here https://crowdin.geokrety.org/ 🤷

@kumy kumy closed this as completed Jan 10, 2024
kumy added a commit that referenced this issue Jan 10, 2024
@kumy
fix: Fix codacy issues
0987673 
Relates #904
This was referenced Jan 10, 2024
Merged
Merged
@kumy
Copy link
Member

kumy commented Jan 11, 2024 •
edited
Loading

How can this be done and can we be helpful in carrying out this task?

Create a wiki page explaining how to accomplish "this" based on the commits linked in this issue

@kumy
Copy link
Member

kumy commented Jan 11, 2024 •
edited
Loading

I forgot to create the related Integration tests

@kumy kumy reopened this Jan 11, 2024
@kumy
Copy link
Member

kumy commented May 19, 2024

tests added in ab3c0fa

@kumy kumy closed this as completed May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-medium- Difficulty to fix: medium Contributions welcomed Feel free to contribute to the project enhancement New feature or request _LOW Low: Not user blocking new-theme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kumy @Detroit70