[TASK] Improve code #2557
Merged
[TASK] Improve code #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please don't squash these commits but use rebase merge instead. |
|
Please rebase to fix the tests |
simonschaufi
force-pushed
the
improve-code
branch
2 times, most recently
from
98eda4c
to
2f46fe7
Compare
simonschaufi
force-pushed
the
improve-code
branch
from
2f46fe7
to
5a31f5b
Compare
|
@georgringer can you please have a look at this? |
|
@simonschaufi for future I would like to avoid such simple looking code changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.