-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPISOA and TotalOC not correctly represented in benchmark #2321
Labels
Comments
yantosca
added
Attn: Aerosols WG
topic: Aerosols
Related to aerosol species in GEOS-Chem
labels
Jun 14, 2024
Thanks @yuanjianz for this. Would you be able to prepare a PR for this? |
yantosca
added a commit
that referenced
this issue
Jul 16, 2024
This merge brings PR #2315 (ix bugs in PDER, OCPISOA and TotalOC in complexSOA, by @yuanjianz) into the GEOS-Chem 14.5.0 development stream. This PR fixes several minor bugs in the complex SOA scheme as described in issues #2314 and #2321. Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Closing this issue as PR #2315 has been merged into the GEOS-Chem 14.5.0 development stream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Your name
Yuanjian Zhang
Your affiliation
WashU
What happened? What did you expect to happen?
OCPISOA
OCPISOA in benchmark simulation (simpleSOA and complexSOA are both carried) double counts ISOAAQ as was in PM2.5.
geos-chem/GeosCore/aerosol_mod.F90
Lines 764 to 799 in 1ef3d7f
ISOAAQ should be added inside the elseif above to avoid this double-counting.
TotalOC
TotalOC only includes Isoprene SOA OC in complexSOA_nonSVPOA, where both POA and OPOA are not present.
geos-chem/GeosCore/diagnostics_mod.F90
Lines 2189 to 2200 in 1ef3d7f
It should match what is happening in aerosol_mod.F90
geos-chem/GeosCore/aerosol_mod.F90
Lines 502 to 511 in 1ef3d7f
What are the steps to reproduce the bug?
run a fullchem benchmark simulation
Please attach any relevant configuration and log files.
No response
What GEOS-Chem version were you using?
14.4.0
What environment were you running GEOS-Chem on?
Local cluster
What compiler and version were you using?
gcc 10.2.0
Will you be addressing this bug yourself?
Yes
In what configuration were you running GEOS-Chem?
Other (please explain in additional information section below)
What simulation were you running?
Full chemistry
As what resolution were you running GEOS-Chem?
N/A
What meterology fields did you use?
Other (please explain in additional information section below)
Additional information
No response
The text was updated successfully, but these errors were encountered: