Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How use with Open Layers 6 #16

Open
TuxGit opened this issue Jan 19, 2020 · 5 comments
Open

How use with Open Layers 6 #16

TuxGit opened this issue Jan 19, 2020 · 5 comments

Comments

@TuxGit
Copy link

TuxGit commented Jan 19, 2020

Hi! Thx for this project to test geotiffjs with ol.

I try to run code from github and its ok! (ol v4)
But then I upgrade ol to latest version (v6) my tiff image displayed wrong. There are no errors in the console. (yes, i renamed imports like import Tile from 'ol/tile'; -> import Tile from 'ol/Tile';)

I'm not as well versed in the depths ol. Why did it break? can someone tell me how to fix it)

open layers 4.6.5
ol4

open layers 6.1.1
ol6

@constantinius
Copy link
Member

Hey @TuxGit

Thanks for your interest in geotiff-js/COG-explorer!

To be honest, it is hard to tell, where it is going wrong exactly. We did various quirks to make the rendering run for that version, which apparently do not work for v6 anymore.

I'll have a look and will see whether this can be easily fixed.

@olivierdalang
Copy link

It would be really awesome if this work was packaged in a reusable way (such as a ol.source.Cog class). COG are awesome, but unfortunately you seem to be the only one so far who was able to implement them with Openlayers !

(see cogeotiff/www.cogeo.org#36 and openlayers/openlayers#10733)

@constantinius
Copy link
Member

I don't want to spoil anything, but this is what @IvanSanchez is working on: https://github.com/IvanSanchez/openlayers/tree/webgl-wip

The main issue is that a TIFF does not necessarily mean that it is visual. Otherwise browsers would have had native support ages ago :-)

@olivierdalang
Copy link

That's great news !! @IvanSanchez please let me know if I can help (for instance by testing)

@mortac8
Copy link

mortac8 commented Oct 5, 2020

Hi! Thx for this project to test geotiffjs with ol.

I try to run code from github and its ok! (ol v4)
But then I upgrade ol to latest version (v6) my tiff image displayed wrong. There are no errors in the console. (yes, i renamed imports like import Tile from 'ol/tile'; -> import Tile from 'ol/Tile';)

I'm not as well versed in the depths ol. Why did it break? can someone tell me how to fix it)

@TuxGit
How did you get OpenLayers 6.1.1 to work at all? When I tried OpenLayers 6.4.3, I didn't have access to ol.Tile to do extend class CanvasTile extends Tile so I had to stick with OpenLayers 4.6.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants