Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit violation followed by empty reply using OAuth (v0.11.3) #66

Open
gerwaric opened this issue Aug 20, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@gerwaric
Copy link
Owner

I was just refreshing my league tabs and the 18th request triggered a rate limit violation. The request was resent after the required delay, however the second response to this was empty.

Here is the relevant section from my log file:

TRACE 2024-08-20T09:22:03.154 RateLimitManager::ActivateRequest() "stash-request-limit" next_send before adjustment is "Tue Aug 20 09:22:05 2024" (in 1 seconds)
DEBUG 2024-08-20T09:22:03.154 "Rate limit policy 'stash-request-limit' is BORDERLINE, added 2000 msecs to send at Tue Aug 20 09:22:07 2024"
TRACE 2024-08-20T09:22:03.154 RateLimitManager::ActivateRequest() waiting 3846 msecs to send request 18 at "Tue Aug 20 09:22:07 2024"
TRACE 2024-08-20T09:22:03.154 RateLimiter::OnManagerPaused() entered
TRACE 2024-08-20T09:22:03.154 RateLimiter::OnManagerPaused() pausing until "Tue Aug 20 09:22:07 2024" for "stash-request-limit"
TRACE 2024-08-20T09:22:04.153 RateLimiter::SendStatusUpdate() entered
TRACE 2024-08-20T09:22:05.152 RateLimiter::SendStatusUpdate() entered
TRACE 2024-08-20T09:22:06.150 RateLimiter::SendStatusUpdate() entered
TRACE 2024-08-20T09:22:07.011 RateLimitManager::SendRequest() entered
TRACE 2024-08-20T09:22:07.011 "stash-request-limit" sending request 18 to "GET /stash//<stash_id>[/<substash_id>]" via "https://api.pathofexile.com/stash/Settlers/ef10d74c78"
TRACE 2024-08-20T09:22:07.011 OAuthManager::setAuthorization() entered
TRACE 2024-08-20T09:22:07.129 RateLimitManager::ReceiveReply() entered
TRACE 2024-08-20T09:22:07.129 RateLimitManager::ReceiveReply() "stash-request-limit" received reply for request 18 with status 429
TRACE 2024-08-20T09:22:07.129 RateLimitManager::ReceiveReply() "stash-request-limit" adding to history: "Tue Aug 20 09:22:04 2024"
TRACE 2024-08-20T09:22:07.129 RateLimitManager::Update() entered
TRACE 2024-08-20T09:22:07.129 RateLimitManager::Update() parsing policy
TRACE 2024-08-20T09:22:07.129 RateLimit::Policy::Policy() entered
TRACE 2024-08-20T09:22:07.129 RateLimit::PolicyRule::PolicyRule() entered
ERROR 2024-08-20T09:22:07.129 "Rate limit policy 'stash-request-limit:Account' is VIOLATION)"
TRACE 2024-08-20T09:22:07.129 RateLimitManager::Update() "stash-request-limit" checking update against existing policy
TRACE 2024-08-20T09:22:07.129 RateLimit::Policy::Check() entered
TRACE 2024-08-20T09:22:07.129 RateLimit::PolicyRule::Check() entered
TRACE 2024-08-20T09:22:07.129 RateLimiter::OnPolicyUpdated() entered
ERROR 2024-08-20T09:22:07.130 Rate limit VIOLATION for policy "stash-request-limit" (retrying after 62 seconds)
TRACE 2024-08-20T09:22:07.155 RateLimiter::SendStatusUpdate() entered
TRACE 2024-08-20T09:22:07.155 RateLimiter::SendStatusUpdate() stopping status updates
TRACE 2024-08-20T09:23:09.119 RateLimitManager::SendRequest() entered
TRACE 2024-08-20T09:23:09.119 "stash-request-limit" sending request 18 to "GET /stash//<stash_id>[/<substash_id>]" via "https://api.pathofexile.com/stash/Settlers/ef10d74c78"
TRACE 2024-08-20T09:23:09.119 OAuthManager::setAuthorization() entered
TRACE 2024-08-20T09:23:09.371 RateLimitManager::ReceiveReply() entered
TRACE 2024-08-20T09:23:09.371 RateLimitManager::ReceiveReply() "stash-request-limit" received reply for request 18 with status 200
TRACE 2024-08-20T09:23:09.371 RateLimitManager::ReceiveReply() "stash-request-limit" adding to history: "Tue Aug 20 09:23:07 2024"
TRACE 2024-08-20T09:23:09.371 RateLimitManager::Update() entered
TRACE 2024-08-20T09:23:09.371 RateLimitManager::Update() parsing policy
TRACE 2024-08-20T09:23:09.371 RateLimit::Policy::Policy() entered
TRACE 2024-08-20T09:23:09.371 RateLimit::PolicyRule::PolicyRule() entered
TRACE 2024-08-20T09:23:09.371 RateLimitManager::Update() "stash-request-limit" checking update against existing policy
TRACE 2024-08-20T09:23:09.371 RateLimit::Policy::Check() entered
TRACE 2024-08-20T09:23:09.371 RateLimit::PolicyRule::Check() entered
TRACE 2024-08-20T09:23:09.371 RateLimiter::OnPolicyUpdated() entered
ERROR 2024-08-20T09:23:09.371 Cannot complete the rate limited request because the reply is null.

@gerwaric gerwaric added the bug Something isn't working label Aug 20, 2024
@gerwaric gerwaric self-assigned this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant