Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items with a current offer buyout ("c/o") are not indexed by the official trade site #67

Open
GoLD-ReaVeR opened this issue Sep 7, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@GoLD-ReaVeR
Copy link

So I used the tool to generate this forum post:
https://www.pathofexile.com/forum/view-thread/3570530

But when I search poe trade the trades there are not listed. Am I doing something wrong? I tried googling but I just get a shitload of garbage to weed through.

@gerwaric
Copy link
Owner

gerwaric commented Sep 7, 2024

Thanks for letting me know.

I think I saw this working a few weeks ago while I was working on another bug, but the shop function is one of the parts of acquisition I'm least familiar with. I will look into it and get back to you.

@GoLD-ReaVeR
Copy link
Author

I found the problem, apparently current offer (c/o) lists the item as if no price was provided. Using buyout everything works fine now.

@gerwaric gerwaric self-assigned this Sep 11, 2024
@gerwaric gerwaric added the bug Something isn't working label Sep 11, 2024
@gerwaric
Copy link
Owner

gerwaric commented Sep 11, 2024

Thanks for digging in. That's clearly a bug--I will see if I can figure out what's going on.

@gerwaric
Copy link
Owner

gerwaric commented Sep 11, 2024

I think I've found the source of this problem. In-game, there are only three pricing options as of 3.25:

  1. Exact price (also called fixed price), which is indicated by a note like "~price 10 chaos"
  2. Negotiable price, which is indicated by a note like "~b/o 10 chaos"
  3. Do Not Index

There is evidence in the forums that "c/o" had been used in the past, but the latest item I can find listed with this tag is almost ten years old. I'm tempted to remove the "Current Offer" option from acquisition now, especially since the trade site doesn't index items priced this way, which will probably confuse people.

What do you think?

@GoLD-ReaVeR
Copy link
Author

I'm relatively new to this so I wouldn't put too much weight on my opinion. However logically speaking if those 3 are the only ones available to the trading site then it's probably best to only support those 3 in the application. Perhaps have a setting somewhere to expose the older options in case someone actually needs them for something.

@gerwaric
Copy link
Owner

I'm going to have acquistion log a warning message for now, with the plan to remove the "c/o" buyout option entirely in a future release--assuming someone doesn't get back to me about why this feature is useful for them.

@gerwaric gerwaric changed the title My shop page doesn't seem to show up on poe trade Items with a current offer buyout ("c/o") are not indexed by the official trade site Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants