Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Display profile header for account related pages #2521

Closed
rolznz opened this issue Jun 29, 2023 · 7 comments · Fixed by #2538
Closed

[Feature] Display profile header for account related pages #2521

rolznz opened this issue Jun 29, 2023 · 7 comments · Fixed by #2538
Assignees
Labels
idea A feature idea that needs to be more specification

Comments

@rolznz
Copy link
Contributor

rolznz commented Jun 29, 2023

Feature description

Currently you can have one account selected and edit another one, but in account subpages it is not obvious which account you are editing.

Describe the solution

  • Display the profile header on subpages of the account. (currently I think only the secret key related things are "below" the account).

Describe alternatives

No response

Additional context

No response

Are you working on this?

None

@rolznz rolznz added the idea A feature idea that needs to be more specification label Jun 29, 2023
@lujakob
Copy link
Contributor

lujakob commented Jun 29, 2023

I could pick it, if no one is on it.

Should the accounts list page be removed as well, right?

@rolznz
Copy link
Contributor Author

rolznz commented Jun 29, 2023

@lujakob thanks. This issue needs to be reviewed first. Also, it would be good for this PR to be merged first

@bumi
Copy link
Collaborator

bumi commented Jul 3, 2023

can't we just keep this account header on the new edit pages
image

we had especially added this feature before.

@reneaaron
Copy link
Contributor

I also don't think we should remove the functionality to edit other accounts than the currently used one.

+1 for displaying the profile header on subpages of the account. (currently I think only the secret key related things are "below" the account).

@reneaaron reneaaron changed the title [Feature] Only allow editing the currently selected account [Feature] Display profile header for account related pages Jul 3, 2023
@lujakob
Copy link
Contributor

lujakob commented Jul 3, 2023

@reneaaron is the issue description still accurate? I'm kind of confused with Bumis comment.

@rolznz
Copy link
Contributor Author

rolznz commented Jul 4, 2023

I updated the description. I believe we should follow Bumi's comment (add a header to new pages). @lujakob please note for now this is just: import/generate/backup secret key, and nostr settings pages (all added in the mnemonic PR which was just merged)

@reneaaron
Copy link
Contributor

@lujakob Sorry I didn't clarify that enough. We should try to add the profile header as kind of a Layout for account related subpages so it's clear which account you are currently editing your keys of.

@rolznz Thanks for updating the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea A feature idea that needs to be more specification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants