Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: e.payment_hash is null #2929

Open
1 task done
KainerW opened this issue Dec 12, 2023 · 8 comments · May be fixed by #3074
Open
1 task done

Error: e.payment_hash is null #2929

KainerW opened this issue Dec 12, 2023 · 8 comments · May be fixed by #3074
Assignees

Comments

@KainerW
Copy link

KainerW commented Dec 12, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Opened up my browser extension today and it shows "Error: e.payment_hash is null" at the bottom.

What could have happenend?

Screenshots [optional]

Screenshot at Dec 12 11-07-20

Steps To Reproduce

Just look into your browser extension and see it at the bottom.

Expected behavior

I expect that mesage to just not be there and my recent transaction loading and showing.

Alby information

3.4.1

Installed to browser via extensions mozilla/firefox.

Device information

firefox 120.0.1

Additional context

No response

Are you working on this?

No

@reneaaron
Copy link
Contributor

@KainerW Thanks for reporting. Could you share which connector you are using?

@dienummer
Copy link

Happens to me with LNDHub

I had to nuke my entire LNDHub redis database to make it stop. Probably relates to expired unpaid invoices.

I just wanted to use nostr TBH

@reneaaron
Copy link
Contributor

@dienummer Can you share some details about what LNDHub you are running? lndhub.go?

@dienummer
Copy link

dienummer commented Feb 27, 2024

@dienummer Can you share some details about what LNDHub you are running? lndhub.go?

https://github.com/BlueWallet/LndHub

Not gonna lie, I didn't know about lndhub.go (or maybe vaguely think I remember hearing about it, but forgot).

@reneaaron
Copy link
Contributor

@pavanjoshi914 Can you maybe look into this? Could we keep the field paymentHash optional for the LNDHub connector?

@pavanjoshi914 pavanjoshi914 linked a pull request Mar 11, 2024 that will close this issue
6 tasks
@pavanjoshi914
Copy link
Contributor

as far as i understand this error shall be thrown by getTransactions action.

null values are returned when payment_hash field is not present in the object itself. but we create responses returned from the connector manually. so payment_hash is always there to be consumed by getTransactions action

i also tried assigning null value to payment_hash and try but still worked for me. no error. still here is the fix #3074

@reneaaron
Copy link
Contributor

Well then let's first try to understand the underlying problem. I don't think we just want to throw code on unclear problems.

According to the docs this field should always be there, too:
https://github.com/BlueWallet/LndHub/blob/master/doc/Send-requirements.md#get-getuserinvoices

@dienummer Does this problem still persist for you after nuking your redis? How do you come to the conclusion it's about expired unpaid invoices? Any info would be really helpful to reproduce this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@KainerW @pavanjoshi914 @reneaaron @dienummer and others