Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cats, cats-effect and http4s versions #4

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

janschultecom
Copy link
Contributor

Solves #3

@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #4 into master will increase coverage by 2.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   84.52%   86.58%   +2.06%     
==========================================
  Files           4        4              
  Lines          84       82       -2     
==========================================
  Hits           71       71              
+ Misses         13       11       -2
Impacted Files Coverage Δ
...s/src/main/scala/platypus/http4s/Http4sVault.scala 75.67% <66.66%> (+3.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 591fe92...fd25aeb. Read the comment docs.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Generally looks correct to me. One possible bit of cruft.

project/versions.scala Outdated Show resolved Hide resolved
@janschultecom
Copy link
Contributor Author

Can we merge this?

@rossabaker
Copy link
Member

I don't have release keys anymore. I would ask on Nelson Gitter about a release if you need one.

@rossabaker rossabaker merged commit 5c9b9d0 into getnelson:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants