Skip to content

Commit

Permalink
test/e2e/s3: relax regex for failed connection (#1341)
Browse files Browse the repository at this point in the history
Node 22 introduced deprecation warnings which changed the stderr output of `lib/bin/s3.js`, breaking a test assertion.

Related #1340 
Closes #1339
  • Loading branch information
alxndrsn authored Dec 10, 2024
1 parent 4355d9e commit c9a3b65
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions test/e2e/s3/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -247,11 +247,7 @@ describe('s3 support', () => {
// then
// N.B. These errors are as observed, and demonstrate that the root error is shared
// with the user. They are not something to try to retain if implementation changes.
await expectRejectionFrom(uploading, new RegExp(
'Command failed: exec node lib/bin/s3 upload-pending\n' +
'(AggregateError.*)?Error: (connect ECONNREFUSED|read ECONNRESET|socket hang up|write EPIPE)',
's',
));
await expectRejectionFrom(uploading, /(AggregateError.*)?Error: (connect ECONNREFUSED|read ECONNRESET|socket hang up|write EPIPE)/);
// and
await assertNewStatuses({ uploaded: 1, failed: 1 });
});
Expand Down

0 comments on commit c9a3b65

Please sign in to comment.