From d3a05b600d02987991cef8eb9ddb9c57a3fccdd4 Mon Sep 17 00:00:00 2001 From: Kim Christensen Date: Sat, 4 May 2024 13:44:49 +0200 Subject: [PATCH 1/2] Remove workflow_dispatch from test-porter-release action Parameters cannot be used when triggered by anything other than workflow_dispatch. As this action is also triggered on PRs targeting the main branch, it cannot use parameters. Signed-off-by: Kim Christensen --- .github/workflows/test-porter-release.yml | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/.github/workflows/test-porter-release.yml b/.github/workflows/test-porter-release.yml index 97444d2da..f0f1bdea9 100644 --- a/.github/workflows/test-porter-release.yml +++ b/.github/workflows/test-porter-release.yml @@ -1,17 +1,5 @@ name: porter/test-porter-release on: - workflow_dispatch: - inputs: - shouldPublish: - description: Should Publish - default: true - type: boolean - required: false - skipTests: - description: Skip Tests - default: true - type: boolean - required: false pull_request: branches: - main @@ -24,5 +12,5 @@ jobs: uses: './.github/workflows/build_pipelinesrelease_template.yml' with: registry: ghcr.io/getporter/test - shouldPublish: ${{ inputs.shouldPublish }} - skipTests: ${{ inputs.skipTests }} + shouldPublish: true + skipTests: true From 5a6a12afd03e54c293535f43c428c38eafbac46d Mon Sep 17 00:00:00 2001 From: Kim Christensen Date: Sun, 5 May 2024 22:27:09 +0200 Subject: [PATCH 2/2] Delete the test-porter-release pipeline The functionality is already covered by the canary release deployment Signed-off-by: Kim Christensen --- .github/workflows/test-porter-release.yml | 16 ---------------- 1 file changed, 16 deletions(-) delete mode 100644 .github/workflows/test-porter-release.yml diff --git a/.github/workflows/test-porter-release.yml b/.github/workflows/test-porter-release.yml deleted file mode 100644 index f0f1bdea9..000000000 --- a/.github/workflows/test-porter-release.yml +++ /dev/null @@ -1,16 +0,0 @@ -name: porter/test-porter-release -on: - pull_request: - branches: - - main -env: - PORTER_PACKAGES_REMOTE: https://github.com/carolynvs/porter-packages.git - PORTER_RELEASE_REPOSITORY: github.com/carolynvs/porter -jobs: - build_pipelinesrelease_template: - name: build_pipelinesrelease_template - uses: './.github/workflows/build_pipelinesrelease_template.yml' - with: - registry: ghcr.io/getporter/test - shouldPublish: true - skipTests: true