Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameters generate command should allow using default values #1604

Closed
carolynvs opened this issue May 24, 2021 · 3 comments
Closed

parameters generate command should allow using default values #1604

carolynvs opened this issue May 24, 2021 · 3 comments
Labels
2 - 🍕 Pizza should be eaten daily gap We missed a spot user experience 🌈💖 Make it easier for everyone to use Porter

Comments

@carolynvs
Copy link
Member

When a parameter has a default value defined, we should allow skipping setting that parameter in the parameter set so that they can use the default value.

Example

$ porter parameters generate hello-llama --reference getporter/hello-llama:v0.1.1
Generating new parameter set hello-llama from bundle hello-llama
==> 2 parameters declared for bundle hello-llama

? How would you like to set parameter "name"
   [Use arrows to move, space to select, type to filter]
  secret
  specific value
  environment variable
  file path
  shell command
> use default value (DEFAULT VALUE)
@carolynvs carolynvs added user experience 🌈💖 Make it easier for everyone to use Porter gap We missed a spot 2 - 🍕 Pizza should be eaten daily labels May 24, 2021
@carolynvs carolynvs mentioned this issue May 24, 2021
3 tasks
@divbhasin
Copy link
Contributor

I would like to work on this :) Did some digging and I think I know what changes need to be made. Just wanted to clarify that the "default" value for a param refers to the following result of running porter explain on hello-llama:

Screen Shot 2021-05-24 at 7 52 10 PM

@carolynvs
Copy link
Member Author

Yup! That is the default value used for the parameter when the user does not specify it. 👍

@kichristensen
Copy link
Contributor

Implemented with a skip option in #3100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - 🍕 Pizza should be eaten daily gap We missed a spot user experience 🌈💖 Make it easier for everyone to use Porter
Projects
Status: Done
Development

No branches or pull requests

3 participants