Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exec mixin requires called executable to be on the path or specified with a relative path #2420

Open
carolynvs opened this issue Oct 14, 2022 · 1 comment
Labels
bug Oops, sorry! hacktoberfest Issues chosen for Hacktoberfest 2023 help wanted Good for someone who has contributed before

Comments

@carolynvs
Copy link
Member

carolynvs commented Oct 14, 2022

Describe the bug

When I rebuilt the otel-jaeger example with porter v1.0.1, I noticed that it broke the bundle. Previously the bundle was running the helpers script with helpers.sh without a relative path prefix. That worked when it was built with porter v1.0.0-alpha.20. Something we did since then broke calling the script that way, and it now gives an error about helpers.sh not being on the path.

To Reproduce

  1. Checkout the example bundles repository
  2. cd to otel-jaeger
  3. porter build && porter install --allow-docker-host-access

Expected behavior

The bundle should install successfully but instead it fails.

Porter Command and Output

$ porter install --allow-docker-host-access
TRUNCATED
/cnab/app helpers.sh set-config
couldn't run command /cnab/app helpers.sh set-config: exec: "helpers.sh": executable file not found in $PATH
Error: couldn't run command /cnab/app helpers.sh set-config: exec: "helpers.sh": executable file not found in $PATH
exit status 1

Version

1.0.1

@carolynvs carolynvs added the bug Oops, sorry! label Oct 14, 2022
@schristoff
Copy link
Member

This issue is linked here too with recreation steps.
Basically, before the exec mixin could be ran like this:

- exec:
      description: "Create OpenTelemetry configuration"
      command: helpers.sh
      arguments:
        - set-config
  - docker-compose:

But now it needs to be:

- exec:
      description: "Create OpenTelemetry configuration"
      command: ./helpers.sh
      arguments:
        - set-config
  - docker-compose:

or else we get the error pasted above. One thing when we go to support this is that it still works for all OSes

@schristoff schristoff added hacktoberfest Issues chosen for Hacktoberfest 2023 help wanted Good for someone who has contributed before labels Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oops, sorry! hacktoberfest Issues chosen for Hacktoberfest 2023 help wanted Good for someone who has contributed before
Projects
None yet
Development

No branches or pull requests

2 participants