-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secret Scanner is notfailing/warning on exposed Secrets. #134
Comments
@Jeffreyhung @mdtro @hubertdeng123 can you take a look please? |
TruffleHog's support for detecting Sentry tokens isn't great. It particularly does not handle our new formats or the org auth tokens. We're working on some contributions to Trufflehog to detect these with more confidence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Sentry Capacitor, using the latest version of Sentry Secrets on each run.
Steps to Reproduce
getsentry/sentry-capacitor#688
On this test PR, I added some secrets for testing the Secret Scanner integration, but it seems like it didn't fail nor trigger to anything (I also included the sample code used on the docs for triggering it).
Expected Result
A warning message or a failed action if secrets were found.
Actual Result
Test passed
The text was updated successfully, but these errors were encountered: