-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate Stackframes #3956
Labels
filler
Requires little effort to resolve. Ready to be picked up anytime.
Comments
jjbayer
added
the
filler
Requires little effort to resolve. Ready to be picked up anytime.
label
Sep 2, 2024
Assuming we would transform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The trimming of stacktraces is currently relatively dumb, it cuts down the total amount of stack frames to 250 then afterwards tries to trim non app frames from the remaining frames until there are 50 frames left.
We can make the trimming smarter by trying to prioritize removing duplicate frames. We probably should keep a few of the duplicates not remove all or communicate in the event metadata that there were duplicate frames removed, to show the user that there were indeed duplicates.
This would help a lot for recursions.
Note duplicate detections does need to be aware of cycles, for example a recursion stack trace could look something like:
x -> a -> a -> a -> a -> a
but also likex -> a -> b -> c -> a -> b -> c -> a -> b -> c
.See also: #3905
The text was updated successfully, but these errors were encountered: