From 63a515dd4120ae923a4832c9558e846e66c21dc4 Mon Sep 17 00:00:00 2001 From: Daniel Szoke Date: Tue, 26 Mar 2024 10:09:38 +0100 Subject: [PATCH] ci: Run Clippy with default features (#1993) We should run Clippy only with the default features. Our features either do nothing (with_crash_reporting) or disable compilation of code (managed). Therefore, somewhat unintuitively, enabling all features leads to the update and uninstall command code to not be linted, since these modules are excluded with the managed feature. Linting with the default feature set ensures all code is linted. Partially unblocks #1992 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0703c0f461..c00c45680b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,7 +28,7 @@ jobs: run: cargo fmt --all -- --check - name: Run Clippy - run: cargo clippy --workspace --all-features --tests -- -D clippy::all + run: cargo clippy --workspace --tests -- -D clippy::all test: strategy: