Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug-files check should search directory recursively #2033

Open
szokeasaurusrex opened this issue Apr 19, 2024 · 0 comments
Open

debug-files check should search directory recursively #2033

szokeasaurusrex opened this issue Apr 19, 2024 · 0 comments

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Apr 19, 2024

While investigating #2032, I discovered that when passed a path to a directory, debug-files upload recursively searches the directory for debug files. However, debug-files check treats the directory as if it were the debug file, and so the command fails with an "unsupported file" error, since a directory is clearly not a debug file that we would support.

Instead, we should recursively search the directory for debug files in the debug-files check command, to match the upload command's behavior. Ideally, we should reuse the recursive searching logic from the upload command.

Or, at a minimum, we should improve the error message when we check a directory. Something like the following could do:

Error: debug-files check can only check individual debug files, but the provided path leads to a directory. Please a pass path to an individual file, instead.

szokeasaurusrex added a commit that referenced this issue Apr 19, 2024
See #2033. This is intended as a quick fix for the issue; we should still consider implementing the recursive check functionality suggested in #2033, since it would provide a better user experience.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant