-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API refactor: Split data types into separate submodules #2077
Comments
Or, perhaps it makes more sense to move this into |
Maybe get @Swatinem or @loewenheim's opinion on that |
Also discussed with @elramen recently that IMO we shouldn’t bloat the SDK with types and definitions that are not directly useful for the SDK itself. |
@Swatinem I was considering that we might implement this change as a new feature under However, you have a fair point – the code would be, at least initially, only used in the CLI, so probably makes more sense to keep the code in the CLI. We can always reevaluate later. Another idea I had would be perhaps that we could work towards splitting off reusable CLI code into a separate library (or perhaps, multiple libraries), which the CLI would use, and which we could reuse elsewhere. But, this would probably be a more long-term initiative |
- Create a new `data_types` submodule under the `api` module. - Crate a `chunking` submodule under the `data_types` module. - Move all data types related to chunking from `src/api/mod.rs` to the `chunking` submodule, splitting their definitions further into submodules under `chunking`. Ref #2077
- Create a new `data_types` submodule under the `api` module. - Crate a `chunking` submodule under the `data_types` module. - Move all data types related to chunking from `src/api/mod.rs` to the `chunking` submodule, splitting their definitions further into submodules under `chunking`. Ref #2077
Data types are types which exist primarily for serializing/deserializing request/response data. Examples include
User
andReleaseStatus
.The text was updated successfully, but these errors were encountered: