Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize chunk uploading logic used to upload debug files #2195

Open
szokeasaurusrex opened this issue Oct 23, 2024 · 0 comments
Open

Generalize chunk uploading logic used to upload debug files #2195

szokeasaurusrex opened this issue Oct 23, 2024 · 0 comments
Assignees
@szokeasaurusrex

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Oct 23, 2024 •
edited
Loading

Refactor the code path used for chunk uploading debug information files to be generalized to support chunk uploading other file types (such as Proguard files). For example, the ChunkedDIFMatch struct can be generalized to also store file types other than DIFs

Depends on #2194
@szokeasaurusrex szokeasaurusrex mentioned this issue Oct 23, 2024
Open
@szokeasaurusrex szokeasaurusrex self-assigned this Nov 28, 2024
szokeasaurusrex added a commit that referenced this issue Nov 28, 2024
@szokeasaurusrex
ref(dif): Replace ChunkedDifMatch with generic ChunkedObject
93897c3 
So that we can reuse the code for chunk uploading difs for other file types as well, replace the `ChunkedDifMatch` struct with a similar, generic type called `ChunkedObject`.

The code path is not fully generic yet, but it is a step in the right direction.

ref #2195
@szokeasaurusrex szokeasaurusrex mentioned this issue Nov 28, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Nov 28, 2024
@szokeasaurusrex
ref(dif): Make try_assemble_dif generic
748d28d 
Now, `try_assemble_dif` can take arbitrary chunked objects (as long as we have a way to convert them into a `ChunkedDifRequest`).

ref #2195
@szokeasaurusrex szokeasaurusrex mentioned this issue Nov 28, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Nov 29, 2024
@szokeasaurusrex
ref(dif): Replace ChunkedDifMatch with generic ChunkedObject
c2c893d 
So that we can reuse the code for chunk uploading difs for other file types as well, replace the `ChunkedDifMatch` struct with a similar, generic type called `ChunkedObject`.

The code path is not fully generic yet, but it is a step in the right direction.

ref #2195
szokeasaurusrex added a commit that referenced this issue Nov 29, 2024
@szokeasaurusrex
ref(dif): Make try_assemble_dif generic
1ca5259 
Now, `try_assemble_dif` can take arbitrary chunked objects (as long as we have a way to convert them into a `ChunkedDifRequest`).

ref #2195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szokeasaurusrex