ref(dif): Rename ToAssemble trait
#2286
Merged
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/into-assemble-request-tuple
branch
from
af2aba1
to
38e7ac9
Compare
loewenheim
reviewed
Nov 29, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/into-assemble-request-tuple
branch
from
38e7ac9
to
c3c0a26
Compare
szokeasaurusrex
changed the title
ToAssemble trait to IntoAssembleRequestTupleToAssemble trait
loewenheim
approved these changes
Nov 29, 2024
szokeasaurusrex
deleted the
szokeasaurusrex/into-assemble-request-tuple
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new name is more specific and descriptive
We also need to change the trait so it is implemented for
&Chunkedrather thanChunked. Otherwise, clippy complains thatinto_*methods should takeselfrather than&self