From c63e60bf5fea8afeb181dd32e83b8e0bea39fb57 Mon Sep 17 00:00:00 2001 From: Karl Heinz Struggl Date: Sat, 25 Nov 2023 08:52:40 -0800 Subject: [PATCH] fix(cordova): fix docs around Cordova Perf and Profiling support (#8562) --- .../getting-started-primer/javascript.cordova.mdx | 2 +- .../configure-sample-rate/javascript.cordova.mdx | 8 ++++++++ src/platforms/common/performance/index.mdx | 3 +-- .../common/performance/instrumentation/index.mdx | 1 - .../instrumentation/automatic-instrumentation.mdx | 2 ++ src/platforms/javascript/common/profiling/index.mdx | 1 + 6 files changed, 13 insertions(+), 4 deletions(-) create mode 100644 src/platform-includes/performance/configure-sample-rate/javascript.cordova.mdx diff --git a/src/platform-includes/getting-started-primer/javascript.cordova.mdx b/src/platform-includes/getting-started-primer/javascript.cordova.mdx index 9df7e9f2ef366..da68c4df52dc5 100644 --- a/src/platform-includes/getting-started-primer/javascript.cordova.mdx +++ b/src/platform-includes/getting-started-primer/javascript.cordova.mdx @@ -18,4 +18,4 @@ Features: - On-device symbolication for JavaScript (in `Debug` mode) - [Ionic support](/platforms/javascript/guides/cordova/ionic/) - Under the hood the SDK relies on our [JavaScript SDK](/platforms/javascript/), which makes all functions available for JavaScript also available in this SDK including: - - [Performance Monitoring](/product/performance/) to create transactions + - [Performance Monitoring](/platforms/javascript/guides/cordova/performance/instrumentation/custom-instrumentation) to create transactions diff --git a/src/platform-includes/performance/configure-sample-rate/javascript.cordova.mdx b/src/platform-includes/performance/configure-sample-rate/javascript.cordova.mdx new file mode 100644 index 0000000000000..fabc9ac0e8a32 --- /dev/null +++ b/src/platform-includes/performance/configure-sample-rate/javascript.cordova.mdx @@ -0,0 +1,8 @@ + + +```javascript +onDeviceReady: function() { + var Sentry = cordova.require("sentry-cordova.Sentry"); + Sentry.init({ dsn: '___PUBLIC_DSN___' }); +} +``` diff --git a/src/platforms/common/performance/index.mdx b/src/platforms/common/performance/index.mdx index d430262f03567..3b16ba90ef41b 100644 --- a/src/platforms/common/performance/index.mdx +++ b/src/platforms/common/performance/index.mdx @@ -22,7 +22,6 @@ supported: - php - node notSupported: - - javascript.cordova - native.breakpad - native.crashpad - native.minidumps @@ -95,7 +94,7 @@ Learn more about performance monitoring + Verify that performance monitoring is working correctly by using our automatic instrumentation or by starting and finishing a transaction using custom instrumentation. diff --git a/src/platforms/common/performance/instrumentation/index.mdx b/src/platforms/common/performance/instrumentation/index.mdx index 89e18ae39a040..2ded003e80cd8 100644 --- a/src/platforms/common/performance/instrumentation/index.mdx +++ b/src/platforms/common/performance/instrumentation/index.mdx @@ -3,7 +3,6 @@ title: Instrumentation sidebar_order: 20 description: "Learn how to instrument performance in your app." notSupported: - - javascript.cordova - native.breakpad - native.crashpad - native.minidumps diff --git a/src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx b/src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx index e623b16d046b2..a3ae64010ce7b 100644 --- a/src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx +++ b/src/platforms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx @@ -3,6 +3,8 @@ title: Automatic Instrumentation sidebar_order: 10 supported: - javascript +notSupported: + - javascript.cordova description: "Learn what transactions are captured after tracing is enabled." redirect_from: - /performance/included-instrumentation diff --git a/src/platforms/javascript/common/profiling/index.mdx b/src/platforms/javascript/common/profiling/index.mdx index 1cc4a1f2d0be9..0b0725ca8f5ec 100644 --- a/src/platforms/javascript/common/profiling/index.mdx +++ b/src/platforms/javascript/common/profiling/index.mdx @@ -5,6 +5,7 @@ supported: - javascript notSupported: - javascript.bun + - javascript.cordova description: "Learn what transactions are captured after tracing is enabled." ---