From 789668df0688672b6ca1897fc812622b47e8812c Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Wed, 9 Aug 2023 10:26:56 +0200 Subject: [PATCH] fix: Don't crash on failed delete after upload (#373) --- packages/bundler-plugin-core/src/debug-id-upload.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/bundler-plugin-core/src/debug-id-upload.ts b/packages/bundler-plugin-core/src/debug-id-upload.ts index 8ef97284..6aea968a 100644 --- a/packages/bundler-plugin-core/src/debug-id-upload.ts +++ b/packages/bundler-plugin-core/src/debug-id-upload.ts @@ -181,7 +181,13 @@ export function createDebugIdUploadFunction({ }); await Promise.all( filePathsToDelete.map((filePathToDelete) => - fs.promises.rm(filePathToDelete, { force: true }) + fs.promises.rm(filePathToDelete, { force: true }).catch((e) => { + // This is allowed to fail - we just don't do anything + logger.debug( + `An error occured while attempting to delete asset: ${filePathToDelete}`, + e + ); + }) ) ); deleteSpan.finish();