From 0dbb4bb213d85f0dfa0f5e34e23ff72cc850eaf9 Mon Sep 17 00:00:00 2001
From: Francesco Novy <francesco.novy@sentry.io>
Date: Tue, 11 Jul 2023 13:42:30 +0200
Subject: [PATCH] test(e2e): Fix types

At least locally I got some type errors here, let's see...
---
 packages/e2e-tests/lib/types.ts  | 2 +-
 packages/e2e-tests/lib/utils.ts  | 4 +---
 packages/e2e-tests/package.json  | 3 ++-
 packages/e2e-tests/tsconfig.json | 1 +
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/e2e-tests/lib/types.ts b/packages/e2e-tests/lib/types.ts
index a86c748ef6d0..f06094ce0426 100644
--- a/packages/e2e-tests/lib/types.ts
+++ b/packages/e2e-tests/lib/types.ts
@@ -47,4 +47,4 @@ export interface RecipeTestResult extends RecipeInstance {
   tests: TestResult[];
 }
 
-export type Env = Record<string, string | string>;
+export type Env = Record<string, string | undefined>;
diff --git a/packages/e2e-tests/lib/utils.ts b/packages/e2e-tests/lib/utils.ts
index 0c786a34f520..b9db25b728a2 100644
--- a/packages/e2e-tests/lib/utils.ts
+++ b/packages/e2e-tests/lib/utils.ts
@@ -19,9 +19,7 @@ interface SpawnAsync {
 
 export function spawnAsync(
   cmd: string,
-  options?:
-    | childProcess.SpawnOptionsWithoutStdio
-    | childProcess.SpawnOptionsWithStdioTuple<childProcess.StdioPipe, childProcess.StdioPipe, childProcess.StdioPipe>,
+  options?: childProcess.SpawnOptions & { timeout?: number },
   input?: string,
 ): Promise<SpawnAsync> {
   const start = Date.now();
diff --git a/packages/e2e-tests/package.json b/packages/e2e-tests/package.json
index 21a8f0e42552..c8b4473d24e4 100644
--- a/packages/e2e-tests/package.json
+++ b/packages/e2e-tests/package.json
@@ -10,9 +10,10 @@
     "fix": "run-s fix:eslint fix:prettier",
     "fix:eslint": "eslint . --format stylish --fix",
     "fix:prettier": "prettier --config ../../.prettierrc.json --write . ",
-    "lint": "run-s lint:prettier lint:eslint",
+    "lint": "run-s lint:prettier lint:eslint lint:ts",
     "lint:eslint": "eslint . --format stylish",
     "lint:prettier": "prettier --config ../../.prettierrc.json --check .",
+    "lint:ts": "tsc --noEmit",
     "test:e2e": "run-s test:validate-configuration test:validate-test-app-setups test:run",
     "test:run": "ts-node run.ts",
     "test:validate-configuration": "ts-node validate-verdaccio-configuration.ts",
diff --git a/packages/e2e-tests/tsconfig.json b/packages/e2e-tests/tsconfig.json
index 2e051315981a..026669f596c0 100644
--- a/packages/e2e-tests/tsconfig.json
+++ b/packages/e2e-tests/tsconfig.json
@@ -1,5 +1,6 @@
 {
   "extends": "../../tsconfig.json",
+  "exclude": ["node_modules", "test-applications"],
   "compilerOptions": {
     "types": ["node"]
   }