Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't do export * from ... in utils package #14211

Open
lforst opened this issue Nov 8, 2024 · 1 comment
Open

Don't do export * from ... in utils package #14211

lforst opened this issue Nov 8, 2024 · 1 comment
Assignees

Comments

@lforst
Copy link
Member

lforst commented Nov 8, 2024

Description

I'd suggest we switch to explicitly exporting values from the package because doing export * from is a bit prone to accidentally export stuff and it is also frowned upon in the ecosystem nowadays because it leads to unnecessarily long compilation times because bundlers have to actually go looking for exports in the imported sources.

@lforst
Copy link
Member Author

lforst commented Nov 8, 2024

@onurtemizkan maybe this is one you could sneak in. We can do this in a non-breaking way by simply looking at the build output of utils and doing identical explicit exports.

@onurtemizkan onurtemizkan self-assigned this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants